Correct the index.js to be required for example/ #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect relative import paths in example files to properly reference the main index.js file. The changes update require statements to use the correct number of directory traversals based on each file's location within the example folder structure.
- Updates require paths from
../index.jsto appropriate relative paths (../../index.jsor../../../index.js) - Corrects rosidl parser imports to use proper relative paths
- Removes unused imports and fixes a syntax error in one file
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| example/topics/validator/validator-example.js | Updates rclnodejs import path from ../index.js to ../../../index.js |
| example/topics/subscriber/*.js | Updates rclnodejs import paths to use correct relative path ../../../index.js |
| example/topics/publisher/*.js | Updates rclnodejs import paths to use correct relative path ../../../index.js |
| example/timer/timer-example.js | Updates rclnodejs import path to ../../index.js |
| example/services/*/*.js | Updates rclnodejs import paths to use correct relative path ../../../index.js |
| example/rosidl/*.js | Updates parser import paths and fixes syntax error in action example |
| example/rate/rate-example.js | Updates rclnodejs import path to ../../index.js |
| example/parameter/*.js | Updates rclnodejs import paths to use correct relative path ../../index.js |
| example/lifecycle/lifecycle-node-example.js | Updates rclnodejs import path to ../../index.js |
| example/graph/ros-graph-example.js | Updates rclnodejs import path to ../../index.js |
| example/actions/*/*.js | Updates rclnodejs import paths and removes unused imports |
|
|
||
| const parser = require('../rosidl_parser/rosidl_parser.js'); | ||
|
|
||
| s; |
There was a problem hiding this comment.
This line contains invalid syntax 's;' which should be removed or replaced with the correct parser import statement.
minggangw
added a commit
that referenced
this pull request
Jul 22, 2025
This PR fixes incorrect relative import paths in example files to properly reference the main index.js file. The changes update require statements to use the correct number of directory traversals based on each file's location within the example folder structure. - Updates require paths from `../index.js` to appropriate relative paths (`../../index.js` or `../../../index.js`) - Corrects rosidl parser imports to use proper relative paths - Removes unused imports and fixes a syntax error in one file Fix: #1202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect relative import paths in example files to properly reference the main index.js file. The changes update require statements to use the correct number of directory traversals based on each file's location within the example folder structure.
../index.jsto appropriate relative paths (../../index.jsor../../../index.js)Fix: #1202